SinceDungeon

🚀 SinceDungeon v1.5.8 - The Customization & Stability Update

This update focuses heavily on expanding your ability to customize dungeons while stabilizing the core gameplay loop, fixing critical timing issues during the completion sequence, and patching edge cases related to inventory management.

✨ New Features & Enhancements

• Per-Dungeon Player Limits: Added a max-players setting to individual dungeon templates, allowing admins to easily separate small standard dungeons from massive, large-scale raids.
• Dynamic RNG Loot Amounts: Reward pools now support Min-Max randomized drop amounts (e.g., DIAMOND:1-5). The system rolls a random quantity within the range upon opening victory chests.
• Advanced Control Zone Mobs: Expanded ControlZoneAction to support spawning both Vanilla and MythicMobs directly on the zone's border with full customization (display names, baby status, equipment, and attributes).
• Smart Leaderboard Privacy: The /dungeon top command now strictly suggests and displays leaderboards only for dungeons marked as public.
• Left-Behind Notifications: Party members who fail to enter a dungeon (due to being dead, too far, or offline) now receive direct chat notifications explaining why they were excluded.
• Command Auto-Completion & Parsing: Upgraded Brigadier argument types to support hyphenated map names. Search logic now uses contains instead of startsWith for a smoother experience.
• In-Game Item Management: Added /dungeon getkey <id> to retrieve system keys for testing. Improved the Editor GUI to recognize these keys via drag-and-drop, automatically converting them to the proper YAML format.
• Standardized Javadocs: Replaced all informal inline notes with professional English Javadocs across core classes.

🎨 Total De-Hardcoding

• Complete Visual & Audio Control: Removed hardcoded Particles and Sounds across all actions (BreakWall, ControlZone, LootChest, ReachLocation, SpawnWave, RandomWave). Everything is now customizable in config.yml.
• Customizable Timings: Title screen timings (fade-in, stay, fade-out) are no longer hardcoded and can be adjusted globally.
• Command Localization: Fixed hardcoded strings in the /dungeon getkey command; it now fully supports language file localization.

🐛 Bug Fixes & Security Patches

• Dungeon Completion Kick Delay: Fixed a bug where kick-delay-after-finish was being ignored, causing players to be instantly teleported out upon killing the final boss. Players will now remain in the dungeon for the configured delay duration to celebrate before being gracefully teleported to the lobby to claim their rewards.
• Life Item Duplication Exploit (Double-Consume Glitch): Patched a double-fire bug where macro-clicking or server latency could cause a single Life Item to be consumed twice (Main-hand/Off-hand double fire). A strict packet cooldown has been implemented to ensure accurate life restoration.
• Reward GUI Teleport Sync: Resolved an edge case where the Reward Gacha GUI would attempt to open before the player had fully finished transitioning across dimensions, occasionally resulting in dropped UI items or closed inventories.
• Item Metadata Fix: Fixed an issue where custom displayName in the reward pool only appeared in chat; it is now correctly applied to the physical ItemMeta of the reward item.
• Mission Item Deep-Clean: Compasses and Keys now safely drop if the inventory is full. Added a strict protocol to aggressively purge all mission items upon leaving to prevent survival world leaks.
• Inventory Wiping Protection: Fixed a race condition where cached inventories were deleted if a player logged out immediately before the async teleportation delay finished.
• Map Griefing Prevention: Decorations (ArmorStands, ItemFrames, Paintings) are now protected from ALL damage sources, including Creepers, TNT, and Mob projectiles.
• Ghost Spectator Glitch: Added validation checks to prevent players from getting stuck in Spectator mode if the dungeon shuts down during their death delay.

⚡ Performance, Architecture & Optimizations

• Memory Management & World Teardown Safety: Refactored DungeonGame#finishDungeon to utilize delayed task scheduling for memory cleanup rather than holding active thread states. Enhanced the WorldManager cleanup task to wait an extra margin to guarantee all players have successfully migrated back to the lobby, preventing "ghost players" from falling into the void.
• Data Restoration: Hardened the restorePlayerState logic, ensuring that if a server crashes mid-dungeon, item wiping is strictly prevented when the plugin shuts down gracefully.
• Editor UI & Item Handling: Minor under-the-hood stability improvements to ItemBuilder to handle 1.21+ advanced NBT components without throwing silent console exceptions on legacy server builds.
• Editor GUI Hot-Reloading: Saving map settings in the Editor now seamlessly hot-reloads the template into live memory without requiring a full server reload.
• Control Zone Softlock: Progress requirements now dynamically calculate based only on actively alive members, preventing softlocks if teammates die.
• Anti-Lag Wall Breaking: Optimized SmartBreakWallAction by reducing the volume limit to 50k blocks and increasing processing speed to 500 blocks/tick to eliminate TPS drops.
• Isolated MythicMobs Architecture: Refactored all actions to route MythicMobs calls through a centralized Hook. This prevents NoClassDefFoundError crashes on servers without the plugin.
• Safe Spawn Algorithm: Refined findSafeSpawn() to scan both upwards and downwards to properly snap monsters to the floor and prevent ceiling suffocation.